Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation] API onHand/onHold spelling fix #7893

Merged
merged 1 commit into from Apr 10, 2017

Conversation

betaglop
Copy link

@betaglop betaglop commented Apr 4, 2017

refs #7886

Q A
Bug fix? yes
New feature? no
BC breaks? yes
Related tickets fixes #7886
License MIT

@betaglop
Copy link
Author

betaglop commented Apr 4, 2017

refs #7889

Copy link
Member

@lchrusciel lchrusciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But can you check other files also? I have seen that the same problem is in docs/api/orders.rst

@betaglop
Copy link
Author

betaglop commented Apr 4, 2017

I'm processing most of your API those days for two projects (one inspired by your API for e-venement, and one extending Sylius for the Blast Project) but I'm progressing step by step. I'll merge every patch I'll do in a single further commit (in this pull resquest probably if not merged to master yet).

@pjedrzejewski pjedrzejewski added API APIs related issues and PRs. Documentation Documentation related issues and PRs - requests, fixes, proposals. labels Apr 10, 2017
@pjedrzejewski pjedrzejewski merged commit 3542cf6 into Sylius:master Apr 10, 2017
@pjedrzejewski
Copy link
Member

Thank you Baptiste!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API APIs related issues and PRs. Documentation Documentation related issues and PRs - requests, fixes, proposals.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistency in the API doc between Orders, Checkouts and Product Variants
3 participants