[CoreBundle] Fix the problem when none shipping method match the current user shipping address #808
Conversation
|
@pjedrzejewski I was not sure about what to use to show that message... Should it be directly in template (where current form should show-up) or in flash like right now? |
| 'order' => $order, | ||
| 'form' => $form->createView(), | ||
| 'context' => $context, | ||
| 'isZoneMatched' => null !== $this->zone, |
There was a problem hiding this comment.
Can't we just check the length of the form in template? (if there is zero child forms, no method is available)
There was a problem hiding this comment.
Not really, I tried to do check on those variables in template, but it ended always with rendering the
|
@pjedrzejewski Ok, I have changed the approach a bit and now I think it's better. It will redirect back to addressing with flash message if user address zone was not matched against shipping zones. |
ghost
assigned
|
@pjedrzejewski It's ready to merge, the bug was fixed, aswell the Behat features now cover this bug too. |
…ent user shipping address Also fix fixtures for countries
[CoreBundle] Fix the problem when none shipping method match the current user shipping address
|
Perfect, thanks for figuring this out! |
Also fix fixtures for countries