[CoreBundle] Move serialization to AdminApiBundle and move ProductVar… #8115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iant relations serialization from ProductBundle to AdminApiBundle
lchrusciel
previously approved these changes
May 30, 2017
|
I don't have a better idea how to tackle it. Can you move relation from the rest of routes? Currently, they aren't useful anyway. |
|
We will need a note in UPGRADE file about it. And also, I'm pretty sure it is BC break, but we need it. |
lchrusciel
added
BC Break
|
Ok, i move a lot of relations, but on some, i have questions
They are not in corebundle, do you want i create them ? |
lchrusciel
requested changes
May 30, 2017
| @@ -24,4 +32,4 @@ Sylius\Component\Core\Model\OrderItem: | |||
| parameters: | |||
| code: expr(object.getVariant().getCode()) | |||
| productCode: expr(object.getVariant().getProduct().getCode()) | |||
| version: 1 | |||
| version: 1 | |||
There was a problem hiding this comment.
Missing blank line at the end of file
| @@ -6,6 +6,14 @@ Sylius\Component\Core\Model\OrderItem: | |||
| expose: true | |||
| groups: [Default, Detailed, DetailedCart] | |||
| relations: | |||
| - rel: order | |||
| exclusion: | |||
| groups: [Default, Detailed, DetailedCart] | |||
There was a problem hiding this comment.
Something went wrong with the indentation
| code: expr(object.getProduct().getCode()) | ||
| version: 1 | ||
| exclusion: | ||
| groups: [Detailed] |
There was a problem hiding this comment.
Missing blank line at the end of file
lchrusciel
requested changes
May 31, 2017
UPGRADE.md
Outdated
| @@ -156,20 +156,79 @@ | |||
| * from `SyliusCoreBundle:Email:userRegistration.html.twig` to `SyliusShopBundle:Email:userRegistration.html.twig` | |||
| * from `SyliusCoreBundle:Email:passwordReset.html.twig` to `SyliusShopBundle:Email:passwordReset.html.twig` | |||
| * from `SyliusCoreBundle:Email:verification.html.twig` to `SyliusShopBundle:Email:verification.html.twig` | |||
|
|
|||
|
|
|||
| * The following serialization configuration was moved from CoreBundle/Resources/config/app/config.yml to AdminApiBundle/Resources/config/app/config.yml | |||
There was a problem hiding this comment.
It should b part of migration from FROM 1.0.0-beta.2 to 1.0.0 (new section)
lchrusciel
approved these changes
May 31, 2017
|
Thank you Nicolas & Łukasz! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…iant relations serialization from ProductBundle to AdminApiBundle
Move serialization from CoreBundle to AdminApiBundle
Move relations of ProductVariant serialization from ProductBundle to AdminApiBundle
I'm not sure to do it the right way @lchrusciel.
If i'm correct, every relations with admin_api routes have to be moved the same way no ?