[Payum] Be2bill onsite implementation #812

winzou · 2014-01-10T11:09:19Z

Be2bill onsite form implementation

winzou · 2014-01-10T11:09:47Z

src/Sylius/Bundle/PayumBundle/Payum/Be2bill/Action/CaptureOrderViaBe2billFormAction.php

+
+            $request->setModel($order);
+
+            //$this->httpRequest->getSession()->set('payum_token', $captureToken->getHash());


@makasim How do I get this $captureToken variable to put its hash in the session?

the only difference from other payments that you have to store token hash to session and configure return\cancel urls in the be2bill admin to redirect to http://your-domain-here.dev/payment/capture/session-token

it could be possible that httpRequest does not have a session. You have to check it and throw exception if session not set.

How do I get this $captureToken variable to put its hash in the session?

@winzou since you are dealing with SecuredCaptureRequest you can get the token from it:

<?php $request->getToken()->getHash();

makasim · 2014-01-10T11:28:10Z

pay attention to payum bundle misses CaptureOnsiteAction service in 0.7.0 version. I've already added to 0.7-dev but not yet released.

winzou · 2014-01-10T13:48:42Z

Hey, thanks to your feedback I fix a bit the action.
But I'm facing a RequestNotSupportedException:

[1] Payum\Core\Exception\RequestNotSupportedException: Request SecuredCaptureRequest{model: ArrayObject} is not supported.
at n/a
    in C:\wamp\www\sylius\vendor\payum\payum\src\Payum\Core\Exception\RequestNotSupportedException.php line 16

at Payum\Core\Exception\RequestNotSupportedException::create(object(SecuredCaptureRequest))
    in C:\wamp\www\sylius\vendor\payum\payum\src\Payum\Core\Payment.php line 98

at Payum\Core\Payment->execute(object(SecuredCaptureRequest))
    in C:\wamp\www\sylius\src\Sylius\Bundle\PayumBundle\Payum\Action\ExecuteSameRequestWithPaymentDetailsAction.php line 39

at Sylius\Bundle\PayumBundle\Payum\Action\ExecuteSameRequestWithPaymentDetailsAction->execute(object(SecuredCaptureRequest))
    in C:\wamp\www\sylius\vendor\payum\payum\src\Payum\Core\Payment.php line 103

at Payum\Core\Payment->execute(object(SecuredCaptureRequest))
    in C:\wamp\www\sylius\src\Sylius\Bundle\PayumBundle\Payum\Be2bill\Action\CaptureOrderViaBe2billFormAction.php line 68

at Sylius\Bundle\PayumBundle\Payum\Be2bill\Action\CaptureOrderViaBe2billFormAction->execute(object(SecuredCaptureRequest))
    in C:\wamp\www\sylius\vendor\payum\payum\src\Payum\Core\Payment.php line 103

I don't really get all the logic of these actions, so I don't know where to investigate?

And what is the CaptureOnsiteAction service you're talking about?

makasim · 2014-01-10T13:51:51Z

@winzou try to update payum bundle to 0.7-dev versoin

winzou · 2014-01-12T08:13:34Z

@makasim It's working with payum/payum 0.7.*@dev and payum/payum-bundle 0.7.1.
So good to merge here as soon as you release 0.7.1 of payum/payum, let us know :)
Thanks!

makasim · 2014-01-12T10:09:39Z

src/Sylius/Bundle/PayumBundle/Payum/Be2bill/Action/CaptureOrderUsingBe2billFormAction.php

+
+            $request->setModel($order);
+
+            $this->httpRequest->getSession()->set('payum_token', $request->getToken()->getHash());


in't this too late to set payum_token. I suppose payum->execute($request) at line 68 throws PostRedirectInteractiveRequest.

makasim · 2014-01-12T10:11:41Z

in general it looks really good, nice work @winzou!

winzou · 2014-01-12T15:11:19Z

@makasim Actually, you don't listen at be2bill notification, am I right?

You only use the return URL that the user will request just after its payment. I find it a bit dangerous, what if the user is badly redirected, or close its tab, or whatever? The payment is done on be2bill side, but we don't know on our side. I think we should rely on the notification URL that be2bill calls. Is it possible?

makasim · 2014-01-12T17:16:40Z

I think we should rely on the notification URL that be2bill calls. Is it possible?

sure it is possible, though it is harder then ipn for paypal. Because we cannot define a token per payment. Same problem was with return\canel url but it was solved by storing token to session. Here in the notifcation we can rely on ORDERID field. Fetch needed order by its value and update payment details and payment state.

winzou · 2014-01-13T02:39:10Z

@makasim so one solution is to build a controller in Payum\PayumBundle that takes the http request, reads the ORDERID and finds the matching token in the db, right? Then, how is the best way to send it back to the classic payum process?

kayue · 2014-01-13T02:50:20Z

@winzou I was discussing the same thing yesterday with @makasim in #725 :)

winzou · 2014-01-13T03:04:49Z

Ah right, I haven't realized. So if you need it too, we should do something generic.
Have you started to write something? Do you agree with the solution I've drafted in my previous comment?

kayue · 2014-01-13T03:15:40Z

I think @makasim's solution is to execute NotifyRequest after received a notification, and then we verify the HTTP request our own action instead.

https://github.com/Payum/PayumBundle/blob/master/Controller/NotifyController.php#L12-L19

makasim · 2014-01-13T06:27:27Z

so one solution is to build a controller in Payum\PayumBundle that takes the http request, reads the ORDERID and finds the matching token in the db, right? Then, how is the best way to send it back to the classic payum process?

payum bundle has to provide similar controller it already has but without token verification. the payment name can be taken from $request->get('payum_payment_name');

Later in the payum action we can find Order by its Id stored in ORDERID field. Having order and notification we can update payment details and dispatch state changed event if required.

makasim · 2014-01-13T08:02:08Z

@kayue exactly! The only problem here we have to pass paymentName. I suggest simply pass it as query parameter or as a route one.

kayue · 2014-01-13T08:08:45Z

@makasim Sounds good to me, thanks 👍

makasim · 2014-01-13T14:43:13Z

I start implementing unsafe notificatoins: Payum/PayumBundle#89.

makasim · 2014-01-13T14:54:00Z

just tested notifactions on sandbox, see on http://sandbox.payum.forma-dev.com/payment/notifications/list. The last unknown notification come from be2bill.

makasim · 2014-01-15T09:16:50Z

src/Sylius/Bundle/PayumBundle/Payum/Be2bill/Action/CaptureOrderUsingBe2billFormAction.php

+{
+    protected $httpRequest;
+
+    public function setRequest(Request $request = null)


makasim · 2014-01-15T09:18:44Z

could you add some specs?

makasim · 2014-01-16T08:09:46Z

PayumBundle 0.7.2 contains a notify action to catch unsafe notifications (one without token). This could be reused here to catch be2bill notifications. I tested it on sandbox, works quite well.

Pay attention that you still have to do some checks before you can trust the notifications data.

winzou · 2014-01-16T09:43:24Z

@makasim See my last commit. How do I transform the request to get it handled by the rest of the process? Which action is the next, CaptureOnsiteAction?

winzou · 2014-01-16T09:44:09Z

btw I need to return http code 200 for be2bill, so request has to be handled for our side (change payment status) + return http 200.

makasim · 2014-01-16T09:45:20Z

btw I need to return http code 200 for be2bill, so request has to be handled for our side (change payment status) + return http 200.

<?php

throw ResponseInteractiveRequest(new Response('', 200));

as the last line of notify action.

makasim · 2014-01-16T09:47:34Z

How do I transform the request to get it handled by the rest of the process? Which action is the next, CaptureOnsiteAction?

there is not standard logic to process notification, you have to put all it here:

get payume status $this->payment->execute(new StatusRequest($order));
dispatch event if state has been changed

winzou · 2014-01-16T10:17:14Z

@makasim how better is it now?

makasim · 2014-01-16T11:02:18Z

src/Sylius/Bundle/PayumBundle/Payum/Be2bill/Action/NotifyAction.php

+
+        $previousState = $order->getPayment()->getState();
+
+        $status = new StatusRequest($order);


hm before getting status you have to update payment details, just merge notifaction with one payment details already have, and set it back to payment

winzou · 2014-01-20T07:05:41Z

@makasim cannot update Payum with Composer:

Problem 1
  - Installation request for payum/payum-bundle ~0.7.2 -> satisfiable by payum/payum-bundle[0.7.2].
  - payum/payum-bundle 0.7.2 requires payum/core 0.8.*@dev -> no matching package found.

I don't think this 0.8.*@dev is good on the requirements for payum-bundle.

makasim · 2014-01-20T08:53:46Z

@winzou my bad, 0.7.3 should be fine.

winzou · 2014-01-22T03:17:38Z

All green and tested with a be2bill account! Good for review and merge @makasim @pjedrzejewski

pjedrzejewski · 2014-01-22T07:20:57Z

src/Sylius/Bundle/CoreBundle/OrderProcessing/PaymentProcessor.php

@@ -46,6 +46,7 @@ public function createPayment(OrderInterface $order)
        $payment = $this->paymentRepository->createNew();

        $payment->setCurrency($order->getCurrency());
+        $payment->setAmount($order->getTotal());


👍 Welcome to the pre-alpha where we forget such things. :D

Let's say it was a feature: free orders for everyone at anytime with no minimum spent 👯

wut? I completely out of the context

When I wrote this payment processor, I forgot to set the correct amount on the payment.

pjedrzejewski · 2014-01-22T07:22:50Z

Looks good to me! The notify action (except the API part) looks like could be abstracted / made more generic in future. Anyway, that's something we do later with next gateway.

👍 from me, I'll give final word on this to @makasim.

[Payum] Be2bill onsite implementation

pjedrzejewski · 2014-01-22T08:07:18Z

Thanks guys! 👍

winzou reviewed Jan 10, 2014
View reviewed changes

ghost assigned winzou Jan 12, 2014

makasim reviewed Jan 12, 2014
View reviewed changes

makasim mentioned this pull request Jan 14, 2014

[payum] version upgrade #839

Merged

makasim reviewed Jan 15, 2014
View reviewed changes

winzou mentioned this pull request Jan 16, 2014

Add a method to test a hash Payum/Payum#103

Closed

makasim reviewed Jan 16, 2014
View reviewed changes

winzou added 4 commits January 20, 2014 12:26

Be2bill onsite implementation

d9bd215

Add SecureNotifyAction

5fc6956

Rename NotifyAction

5e8610e

Update payment details

d8dd546

winzou added 4 commits January 20, 2014 17:20

Update to PayumBundle 0.7.3

99910ae

Add NotifyAction to payum config

4ac4895

Add amount to payment at creation

1360b86

Add EventDispatcher dependency

624a06a

pjedrzejewski reviewed Jan 22, 2014
View reviewed changes

makasim added a commit that referenced this pull request Jan 22, 2014

Merge pull request #812 from winzou/be2bill-onsite

a8f1b9d

[Payum] Be2bill onsite implementation

makasim merged commit a8f1b9d into Sylius:master Jan 22, 2014

winzou deleted the be2bill-onsite branch January 22, 2014 08:02


		$request->setModel($order);

		//$this->httpRequest->getSession()->set('payum_token', $captureToken->getHash());


		$request->setModel($order);

		$this->httpRequest->getSession()->set('payum_token', $request->getToken()->getHash());


		$previousState = $order->getPayment()->getState();

		$status = new StatusRequest($order);

[Payum] Be2bill onsite implementation #812

[Payum] Be2bill onsite implementation #812

Conversation

winzou commented Jan 10, 2014

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

makasim commented Jan 10, 2014

winzou commented Jan 10, 2014

makasim commented Jan 10, 2014

winzou commented Jan 12, 2014

Choose a reason for hiding this comment

makasim commented Jan 12, 2014

winzou commented Jan 12, 2014

makasim commented Jan 12, 2014

winzou commented Jan 13, 2014

kayue commented Jan 13, 2014

winzou commented Jan 13, 2014

kayue commented Jan 13, 2014

makasim commented Jan 13, 2014

makasim commented Jan 13, 2014

kayue commented Jan 13, 2014

makasim commented Jan 13, 2014

makasim commented Jan 13, 2014

Choose a reason for hiding this comment

makasim commented Jan 15, 2014

makasim commented Jan 16, 2014

winzou commented Jan 16, 2014

winzou commented Jan 16, 2014

makasim commented Jan 16, 2014

makasim commented Jan 16, 2014

winzou commented Jan 16, 2014

Choose a reason for hiding this comment

winzou commented Jan 20, 2014

makasim commented Jan 20, 2014

winzou commented Jan 22, 2014

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pjedrzejewski commented Jan 22, 2014

pjedrzejewski commented Jan 22, 2014