Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[InstallerBundle] Fixing translations extension to be consistent with other... #830

Merged
merged 2 commits into from
Jan 15, 2014
Merged

[InstallerBundle] Fixing translations extension to be consistent with other... #830

merged 2 commits into from
Jan 15, 2014

Conversation

jjanvier
Copy link
Contributor

... bundles.

@winzou
Copy link
Contributor

winzou commented Jan 14, 2014

When moving from xliff to xlif, you should also clean the file (like remove the <jms:...> tags, etc.).

@pjedrzejewski
Copy link
Member

@jjanvier Let's add what @winzou said.

@jjanvier
Copy link
Contributor Author

@winzou @pjedrzejewski how do you add new translations ? If you use JMS, this means you clean your files before commiting ??

@pjedrzejewski
Copy link
Member

Usually I do "extract" and for some reason... it does not add "jms-reference" anymore. I just realized that, no idea why.

@winzou
Copy link
Contributor

winzou commented Jan 14, 2014

Because we use xlf extension and not xliff, that's why it does not generate all these jms-reference.
@jjanvier you can execure the extract command now that the file has the right extension, maybe it will clean the file automaticaly.

@jjanvier
Copy link
Contributor Author

@winzou thanks for the clarification. I'll do this ;)

@jjanvier
Copy link
Contributor Author

@winzou @pjedrzejewski done. But English translations were OK. And we should not care about other translations as they should come from the Crowdin export. I'm working on it, and I hope we will have something cool really soon ;)

@jjanvier
Copy link
Contributor Author

ping @pjedrzejewski ok ?

pjedrzejewski pushed a commit that referenced this pull request Jan 15, 2014
[InstallerBundle] Fixing translations extension to be consistent with other...
@pjedrzejewski pjedrzejewski merged commit c819509 into Sylius:master Jan 15, 2014
@pjedrzejewski pjedrzejewski deleted the fix/installer-translations-format branch January 15, 2014 21:34
@pjedrzejewski
Copy link
Member

Yep, thanks Julien! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants