-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[InstallerBundle] Fixing translations extension to be consistent with other... #830
[InstallerBundle] Fixing translations extension to be consistent with other... #830
Conversation
When moving from xliff to xlif, you should also clean the file (like remove the |
@winzou @pjedrzejewski how do you add new translations ? If you use JMS, this means you clean your files before commiting ?? |
Usually I do "extract" and for some reason... it does not add "jms-reference" anymore. I just realized that, no idea why. |
Because we use |
@winzou thanks for the clarification. I'll do this ;) |
@winzou @pjedrzejewski done. But English translations were OK. And we should not care about other translations as they should come from the Crowdin export. I'm working on it, and I hope we will have something cool really soon ;) |
ping @pjedrzejewski ok ? |
[InstallerBundle] Fixing translations extension to be consistent with other...
Yep, thanks Julien! 👍 |
... bundles.