Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation][ShopBundle][TheBook] twig money format helpers #8368

Merged
merged 4 commits into from Aug 29, 2017

Conversation

Mipme
Copy link
Contributor

@Mipme Mipme commented Aug 4, 2017

Q A
Bug fix? no
New feature? no
BC breaks? no
Related tickets none
License MIT

Handy Money Format helpers are already there in Sylius - but not
documented. Here u go! ;-)

…pers

Handy Money Format helpers are already there in Sylius - but not
documented. Here u go! ;-)
@@ -71,6 +71,22 @@ the ``Sylius\Component\Core\Currency\CurrencyStorageInterface`` with methods

$container->get('sylius.storage.currency')->set($channel, 'PLN');

Displaying Currencies in a templates
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...in the templates

@pjedrzejewski pjedrzejewski added this to the v1.0.0 milestone Aug 8, 2017
@lchrusciel
Copy link
Member

@Mipme would you like to add the change proposed by @CoderMaggie?

@@ -71,6 +71,22 @@ the ``Sylius\Component\Core\Currency\CurrencyStorageInterface`` with methods

$container->get('sylius.storage.currency')->set($channel, 'PLN');

Displaying Currencies in the templates
------------------------------------
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing two last dashes

@CoderMaggie CoderMaggie merged commit aa937d4 into Sylius:master Aug 29, 2017
@CoderMaggie
Copy link
Member

Thank you @Mipme ;) 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants