Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Mailer] Scalar types in Mailer #8429

Merged
merged 2 commits into from Aug 22, 2017
Merged

[Mailer] Scalar types in Mailer #8429

merged 2 commits into from Aug 22, 2017

Conversation

Zales0123
Copy link
Member

@Zales0123 Zales0123 commented Aug 22, 2017 •
edited

Q A
Bug fix? no
New feature? no
BC breaks? yes
Related tickets #8425
License MIT

@Zales0123 Zales0123 added BC Break PRs introducing BC breaks (do not even try to merge). Maintenance CI configurations, READMEs, releases, etc. Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). and removed Maintenance CI configurations, READMEs, releases, etc. labels Aug 22, 2017
@pamil pamil mentioned this pull request Aug 22, 2017
Closed
30 tasks
@pamil pamil added the PHP 7.1 label Aug 22, 2017
pamil
pamil suggested changes Aug 22, 2017
View reviewed changes
src/Sylius/Component/Mailer/Model/Email.php Outdated
{
$this->enabled = false;
}

/**
* {@inheritdoc}
*/
public function getSubject()
public function getSubject(): string
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can return null if called before setter.

src/Sylius/Component/Mailer/Model/Email.php Outdated
{
$this->subject = $subject;
}

/**
* {@inheritdoc}
*/
public function getContent()
public function getContent(): string
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can return null if called before setter.

@pamil pamil added this to the v1.0.0 milestone Aug 22, 2017
@pamil pamil merged commit c6c6ec9 into Sylius:master Aug 22, 2017
@pamil
Copy link
Contributor

pamil commented Aug 22, 2017

Thanks Mateusz! 🎉

@Zales0123 Zales0123 deleted the scalar-types-mailer branch August 22, 2017 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pamil pamil pamil approved these changes

Assignees
No one assigned
Labels
BC Break PRs introducing BC breaks (do not even try to merge). Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Zales0123 @pamil