[Resource] Use typehints introduced by PHP7+ #8439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pamil
commented
Aug 23, 2017
pamil
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | yes |
| Related tickets | part of #8425 |
| License | MIT |
pamil
added
BC Break
pamil
force-pushed
the
scalar-types/resource
branch
3 times, most recently
from
4eb8b41
to
1e4d7b6
Compare
Zales0123
approved these changes
Aug 24, 2017
| @@ -115,7 +115,7 @@ protected function getModelNamespace() | |||
| * | |||
| * @throws UnknownDriverException | |||
| */ | |||
| protected function getMappingCompilerPassInfo($driverType) | |||
| protected function getMappingCompilerPassInfo($driverType): array | |||
| @@ -32,11 +32,20 @@ public function createRouteCollection(); | |||
| * @param array $requirements An array of requirements for parameters (regexes) | |||
| * @param array $options An array of options | |||
| * @param string $host The host pattern to match | |||
| * @param string|array $schemes A required URI scheme or an array of restricted schemes | |||
| * @param string|array $methods A required HTTP method or an array of restricted methods | |||
| * @param array $schemes A required URI scheme or an array of restricted schemes | |||
There was a problem hiding this comment.
I would change the comment to A required array of restricted schemes or remove it at all.
| * @param string|array $schemes A required URI scheme or an array of restricted schemes | ||
| * @param string|array $methods A required HTTP method or an array of restricted methods | ||
| * @param array $schemes A required URI scheme or an array of restricted schemes | ||
| * @param array $methods A required HTTP method or an array of restricted methods |
| @@ -19,16 +19,18 @@ | |||
| interface ToggleableInterface | |||
| { | |||
| /** | |||
| * Missing scalar typehint because it conflicts with AdvancedUserInterface. | |||
pamil
force-pushed
the
scalar-types/resource
branch
from
1e4d7b6
to
34323aa
Compare
30 tasks
Zales0123
approved these changes
Aug 24, 2017
|
Great work Kamil! 🌕 |
Merged
pamil
pushed a commit
to pamil/Sylius
that referenced
this pull request
May 7, 2019
[Resource] Use typehints introduced by PHP7+
pamil
pushed a commit
to pamil/Sylius
that referenced
this pull request
May 7, 2019
[Resource] Use typehints introduced by PHP7+
pamil
pushed a commit
to pamil/Sylius
that referenced
this pull request
May 7, 2019
[Resource] Use typehints introduced by PHP7+
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.