Use right form types and default data for the "add production promotion action" #863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's an idea for later, but we should use some production autocompletion field. Or maybe a combination of two inputs, one for selecting the product (if product does not have variants, it returns the master variant) and other one fo r the variant. (be it combination of options or just list of the variants. I'll work on this. Not sure how to approach the autocomplete part... We should figure out some common approach for all ajax based forms. |
|
I just discovered a bug where you can clone items, it's hilarious. :D I'll address it in another PR as these are not related. |
pjedrzejewski
pushed a commit
that referenced
this pull request
Jan 18, 2014
Use right form types and default data for the "add production promotion action"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @winzou
Previous the
dataoption was preventing the new configuration from saving. Also the user had to enter the price in the smallest units, now it uses the money field.