Do not crash admin while listing partially shipped orders #8718
Conversation
pamil
commented
Sep 21, 2017
•
pamil
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Related tickets | fixes #8717; fixes #8719 |
| License | MIT |
| @@ -0,0 +1,4 @@ | |||
| <span class="ui blue{% if attached is defined and attached == true %} top attached{% endif %} label"> | |||
There was a problem hiding this comment.
ready state is blue, maybe different colour? 🎉
There was a problem hiding this comment.
No idea though, partially shipped is something between ready & shipped, blue & green, clock & plane; the most important thing here is not to crash admin interface, I'm open for colour / icon suggestions though :)
There was a problem hiding this comment.
Like in payments, partially paid has the same colour as cancelled one. I'll make it the same here then 🗡
|
There is also missing template for a |
pamil
force-pushed
the
1.0-partially-shipped
branch
from
b5b3155
to
5bd0ee4
Compare
|
@GSadee colours & icons adjusted (for both partially refunded and partially shipped) 🎉 |
| @@ -0,0 +1,4 @@ | |||
| <span class="ui yellow{% if attached is defined and attached == true %} top attached{% endif %} label"> | |||
There was a problem hiding this comment.
I know, I'm annoying and this is irrelevant, but cancelled state is yellow 😆
There was a problem hiding this comment.
Yeah, that's the same with partially paid and cancelled, which already exists for a while and nobody's been complaining :D
|
Thanks Kamil! 🌮 |
