Do flush after enabling a user in user registration listener #8742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pamil
commented
Sep 26, 2017
pamil
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Related tickets | fixes #8720 |
| License | MIT |
GSadee
approved these changes
Sep 26, 2017
Zales0123
approved these changes
Sep 27, 2017
|
Just wondering, maybe we can provide a scenario that would reproduce this bug to be 100% sure it's correct? |
|
@Zales0123 it's currently working right now cause there's something else in the code making the flush, so e2e scenario won't work correctly in this case. |
|
Great 🌮 |
pamil
pushed a commit
to pamil/Sylius
that referenced
this pull request
May 7, 2019
Do flush after enabling a user in user registration listener
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.