Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed a typo in docs #8750

Merged
merged 1 commit into from
Sep 29, 2017
Merged

Fixed a typo in docs #8750

merged 1 commit into from
Sep 29, 2017

Conversation

dborsatto
Copy link
Contributor

@dborsatto dborsatto commented Sep 28, 2017 •
edited by CoderMaggie
Loading

Q A
Branch? 1.0
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets none
License MIT

@CoderMaggie CoderMaggie changed the base branch from master to 1.0 September 29, 2017 06:29
@CoderMaggie
Copy link
Member

Hi @dborsatto, really nice to have you there as a contributor.
Unfortunately your PR should be opened to 1.0 instead of master, that is why I've changed your base branch, and you need to do a rebase to 1.0. ;)

@CoderMaggie CoderMaggie added the Documentation Documentation related issues and PRs - requests, fixes, proposals. label Sep 29, 2017
@dborsatto
Copy link
Contributor Author

Will do, thanks!

@dborsatto
Copy link
Contributor Author

Should be fine now 🙂

@pamil pamil added this to the 1.0 milestone Sep 29, 2017
@CoderMaggie CoderMaggie merged commit 7e3c96d into Sylius:1.0 Sep 29, 2017
@CoderMaggie
Copy link
Member

Thank you Davide, and welcome to Sylius contributors! 🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pamil pamil pamil approved these changes

Assignees
No one assigned
Labels
Documentation Documentation related issues and PRs - requests, fixes, proposals.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dborsatto @CoderMaggie @pamil