Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug][Admin] Avoid deleting Product Variant when removing the associa… #8762

Merged
merged 1 commit into from
Oct 5, 2017
Merged

[Bug][Admin] Avoid deleting Product Variant when removing the associa… #8762

merged 1 commit into from
Oct 5, 2017

Conversation

ylastapis
Copy link

…tion between product image & variant (admin Product media form)

Q A
Branch? 1.0 or
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

On product admin form, we can now associate product variants to product images.
But removing the association removes also the product variant.

…tion between product image & variant (admin Product media form)
@pjedrzejewski pjedrzejewski added Bug Fix Critical Issues and PRs, which are critical and should be fixed ASAP. labels Oct 3, 2017
@pjedrzejewski pjedrzejewski added this to the 1.0 milestone Oct 3, 2017
@GSadee GSadee merged commit 9b1256c into Sylius:1.0 Oct 5, 2017
@GSadee
Copy link
Member

GSadee commented Oct 5, 2017

Thank you @ylastapis!

@ylastapis ylastapis deleted the fix_product_variant_deletion_on_image_deassociation branch October 26, 2017 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Critical Issues and PRs, which are critical and should be fixed ASAP.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants