Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation] Clarification of how to install assets in a new theme #8791

Merged
merged 1 commit into from
Oct 9, 2017
Merged

[Documentation] Clarification of how to install assets in a new theme #8791

merged 1 commit into from
Oct 9, 2017

Conversation

johnrisby
Copy link
Contributor

@johnrisby johnrisby commented Oct 7, 2017

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets mentioned in #8789
License MIT

Added step 3 in the guide. This is mainly taken from here but when you are reading this page on how to create a theme, you don't know to find that page. One option was to link to that, but as that page is about changes, it seems to make more sense to put it into the core documentation. Merging it in to this page will prevent developers from struggling (as I did) to find out why the issues in ticket #8789 are happening.

I've renamed later steps to accommodate the insertion of step 3.

Probably at some point, the original mention here should be removed.

Thanks to @stefandoorn for help.

@CoderMaggie CoderMaggie merged commit 6570ae4 into Sylius:master Oct 9, 2017
@CoderMaggie
Copy link
Member

Thank you @johnrisby! 👍

@CoderMaggie CoderMaggie added the Documentation Documentation related issues and PRs - requests, fixes, proposals. label Oct 9, 2017
@johnrisby johnrisby deleted the docs/themes branch October 9, 2017 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Documentation related issues and PRs - requests, fixes, proposals.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants