Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Installation] Add setting a username during installation #8798

Merged
merged 2 commits into from
Oct 11, 2017
Merged

[Installation] Add setting a username during installation #8798

merged 2 commits into from
Oct 11, 2017

Conversation

GSadee
Copy link
Member

@GSadee GSadee commented Oct 9, 2017 •
edited

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Related tickets fixes #8613
License MIT

@GSadee GSadee added this to the 1.0 milestone Oct 9, 2017
@GSadee GSadee added the UX label Oct 9, 2017
@pamil
Copy link
Contributor

pamil commented Oct 10, 2017

It looks like a new feature to me (and possibly can break some automated installation procedures).
What about setting the username to be the same as email for 1.0 branch and then adding this additional question in 1.1?

@stefandoorn
Copy link
Contributor

Can't it be an optional parameter?

@GSadee
Copy link
Member Author

GSadee commented Oct 10, 2017

Username is an optional parameter, when it is left blank, email is set as a username. However, I understand that there is a possibility, that this change could break some automated installation procedures as @pamil has written. I will create new PR for 1.0 branch and change the base branch of this PR.

@GSadee GSadee modified the milestones: 1.0, 1.1 Oct 10, 2017
@GSadee GSadee changed the base branch from 1.0 to master October 10, 2017 21:06
@GSadee GSadee mentioned this pull request Oct 10, 2017
Merged
@pamil pamil merged commit b55ca84 into Sylius:master Oct 11, 2017
@pamil
Copy link
Contributor

pamil commented Oct 11, 2017

Thanks! 🍰

@GSadee GSadee deleted the installation branch October 11, 2017 08:53
@pamil pamil added the UX Issues and PRs aimed at improving User eXperience. label Oct 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pamil pamil pamil approved these changes

Assignees
No one assigned
Labels
UX Issues and PRs aimed at improving User eXperience.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot reset password admin without setting up a username
3 participants
@GSadee @pamil @stefandoorn