Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Random codebase enhancements #8832

Merged
merged 1 commit into from
Oct 16, 2017
Merged

Random codebase enhancements #8832

merged 1 commit into from
Oct 16, 2017

Conversation

pamil
Copy link
Contributor

@pamil pamil commented Oct 12, 2017

Q A
Branch? 1.0
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets -
License MIT

@pamil pamil added Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). Maintenance CI configurations, READMEs, releases, etc. labels Oct 12, 2017
@pamil pamil added this to the 1.0 milestone Oct 12, 2017
@pamil pamil self-assigned this Oct 12, 2017
Zales0123
Zales0123 approved these changes Oct 16, 2017
View reviewed changes
Copy link
Member

@Zales0123 Zales0123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 but it fails :(

@pamil pamil merged commit 67afddb into Sylius:1.0 Oct 16, 2017
@pamil pamil deleted the 1.0-random-fixes branch October 16, 2017 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GSadee GSadee GSadee approved these changes

@Zales0123 Zales0123 Zales0123 approved these changes

Assignees

@pamil pamil

Labels
Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). Maintenance CI configurations, READMEs, releases, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pamil @GSadee @Zales0123