Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean the not Fulfilled Table before each collection #8840

Merged

Conversation

nstapelbroek
Copy link
Contributor

Q A
Branch? 1.0
Bug fix? not realy
New feature? no
BC breaks? no
Deprecations? no
Related tickets none
License MIT

Hey ya,

During the installation, when any requirements collection fails it would print out the entire not-fulfilled table of the previous component aswell. This PR introduces a table per collection. As a result this:

PHP version and settings
+-------------------------+----------+
| Requirement             | Status   |
+-------------------------+----------+
| timezone                | ERROR!   |
| Recommended PHP version | WARNING! |
| detect_unicode          | WARNING! |
| session.auto_start      | WARNING! |
+-------------------------+----------+
extensions
+-------------------------+----------+
| Requirement             | Status   |
+-------------------------+----------+
| timezone                | ERROR!   |
| Recommended PHP version | WARNING! |
| detect_unicode          | WARNING! |
| session.auto_start      | WARNING! |
| JSON                    | ERROR!   |
| Session                 | ERROR!   |
| Ctype                   | ERROR!   |
| Tokenizer               | ERROR!   |
| SimpleXML               | ERROR!   |
| APC                     | ERROR!   |
| PCRE                    | ERROR!   |
| PHP-XML                 | WARNING! |
| Multibyte String        | WARNING! |
| Iconv                   | WARNING! |
| Exif                    | ERROR!   |
| Intl                    | ERROR!   |
| Fileinfo                | ERROR!   |
| Accelerator             | WARNING! |
| PDO                     | WARNING! |
| GD                      | ERROR!   |
| ICU                     | WARNING! |
+-------------------------+----------+
file system
+-------------------------+----------+
| Requirement             | Status   |
+-------------------------+----------+
| timezone                | ERROR!   |
| Recommended PHP version | WARNING! |
| detect_unicode          | WARNING! |
| session.auto_start      | WARNING! |
| JSON                    | ERROR!   |
| Session                 | ERROR!   |
| Ctype                   | ERROR!   |
| Tokenizer               | ERROR!   |
| SimpleXML               | ERROR!   |
| APC                     | ERROR!   |
| PCRE                    | ERROR!   |
| PHP-XML                 | WARNING! |
| Multibyte String        | WARNING! |
| Iconv                   | WARNING! |
| Exif                    | ERROR!   |
| Intl                    | ERROR!   |
| Fileinfo                | ERROR!   |
| Accelerator             | WARNING! |
| PDO                     | WARNING! |
| GD                      | ERROR!   |
| ICU                     | WARNING! |
| vendors                 | ERROR!   |
| cache                   | ERROR!   |
| logs                    | ERROR!   |
+-------------------------+----------+

Will be replaced by this:

PHP version and settings
+-------------------------+----------+
| Requirement             | Status   |
+-------------------------+----------+
| timezone                | ERROR!   |
| Recommended PHP version | WARNING! |
| detect_unicode          | WARNING! |
| session.auto_start      | WARNING! |
+-------------------------+----------+
extensions
+------------------+----------+
| Requirement      | Status   |
+------------------+----------+
| JSON             | ERROR!   |
| Session          | ERROR!   |
| Ctype            | ERROR!   |
| Tokenizer        | ERROR!   |
| SimpleXML        | ERROR!   |
| APC              | ERROR!   |
| PCRE             | ERROR!   |
| PHP-XML          | WARNING! |
| Multibyte String | WARNING! |
| Iconv            | WARNING! |
| Exif             | ERROR!   |
| Intl             | ERROR!   |
| Fileinfo         | ERROR!   |
| Accelerator      | WARNING! |
| PDO              | WARNING! |
| GD               | ERROR!   |
| ICU              | WARNING! |
+------------------+----------+
file system
+-------------+--------+
| Requirement | Status |
+-------------+--------+
| vendors     | ERROR! |
| cache       | ERROR! |
| logs        | ERROR! |
+-------------+--------+

The helptable functionality remains untouched.

@GSadee GSadee added the DX Issues and PRs aimed at improving Developer eXperience. label Oct 17, 2017
@GSadee GSadee added this to the 1.0 milestone Oct 17, 2017
@pamil pamil merged commit a6abd7f into Sylius:1.0 Oct 17, 2017
@pamil
Copy link
Contributor

pamil commented Oct 17, 2017

Thanks Nico!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DX Issues and PRs aimed at improving Developer eXperience.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants