New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin naming convention RFC implementation (closes #8848) #8903

Merged
merged 1 commit into from Nov 9, 2017

Conversation

Projects
None yet
6 participants
@stefandoorn
Contributor

stefandoorn commented Oct 25, 2017

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? yes (sort of.. but no in docs)
Deprecations? no
Related tickets fixes #8848
License MIT

After discussion in #8848, hereby the PR. Difference from the discussion is that I've chosen to name the repository after the class bundle name, to have it all consistent and in the same style.

Before merging this, there should also come a PR to the PluginSkeleton to rename things I think.

Show outdated Hide outdated docs/plugins/creating-plugin.rst Outdated
Show outdated Hide outdated docs/plugins/creating-plugin.rst Outdated
@stefandoorn

This comment has been minimized.

Show comment
Hide comment
@stefandoorn

stefandoorn Nov 7, 2017

Contributor

Changed a lot and added examples. Let me know what you think.

Contributor

stefandoorn commented Nov 7, 2017

Changed a lot and added examples. Let me know what you think.

@pamil pamil added this to the 1.0 milestone Nov 8, 2017

@pamil pamil changed the base branch from master to 1.0 Nov 8, 2017

@pamil pamil changed the base branch from 1.0 to master Nov 8, 2017

@pamil

Looks awesome! Can you switch this PR's base branch to 1.0?

Show outdated Hide outdated docs/plugins/creating-plugin.rst Outdated
Show outdated Hide outdated docs/plugins/creating-plugin.rst Outdated

@pamil pamil referenced this pull request Nov 8, 2017

Merged

Follow new naming convention #56

@stefandoorn

This comment has been minimized.

Show comment
Hide comment
@stefandoorn

stefandoorn Nov 8, 2017

Contributor

@pamil I think we are good to go now.

Contributor

stefandoorn commented Nov 8, 2017

@pamil I think we are good to go now.

@stefandoorn stefandoorn changed the base branch from master to 1.0 Nov 8, 2017

@pamil

pamil approved these changes Nov 9, 2017

Great one!

@pamil

This comment has been minimized.

Show comment
Hide comment
@pamil

pamil Nov 9, 2017

Member

This one should be merged together with Sylius/PluginSkeleton#56.

Member

pamil commented Nov 9, 2017

This one should be merged together with Sylius/PluginSkeleton#56.

@pjedrzejewski pjedrzejewski merged commit 1cfcf9c into Sylius:1.0 Nov 9, 2017

2 checks passed

Scrutinizer No new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@pjedrzejewski

This comment has been minimized.

Show comment
Hide comment
@pjedrzejewski

pjedrzejewski Nov 9, 2017

Member

Thank you very much Stefan! 👍 Great work.

Member

pjedrzejewski commented Nov 9, 2017

Thank you very much Stefan! 👍 Great work.

@@ -11,11 +11,11 @@ which has built-in infrastructure for designing and testing using `Behat`_.
.. code-block:: bash
$ composer create-project sylius/plugin-skeleton MyPlugin
$ composer create-project sylius/plugin-skeleton SyliusMyFirstPlugin

This comment has been minimized.

@lsmith77

lsmith77 Nov 9, 2017

Contributor

did you intentional leave out the vendor name here?

@lsmith77

lsmith77 Nov 9, 2017

Contributor

did you intentional leave out the vendor name here?

@lsmith77

This comment has been minimized.

Show comment
Hide comment
@lsmith77

lsmith77 Nov 9, 2017

Contributor

I noticed that the conventions do not see to cover DI service as well as command names. Should this maybe be covered as well?

Contributor

lsmith77 commented Nov 9, 2017

I noticed that the conventions do not see to cover DI service as well as command names. Should this maybe be covered as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment