Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for PHP 7.2 #8908

Merged
merged 2 commits into from
Oct 27, 2017
Merged

Support for PHP 7.2 #8908

merged 2 commits into from
Oct 27, 2017

Conversation

pamil
Copy link
Contributor

@pamil pamil commented Oct 26, 2017

Q A
Branch? 1.0
Bug fix? kinda
New feature? kinda
BC breaks? no
Deprecations? no
Related tickets continues #8868
License MIT

@pamil pamil added Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). PHP 7.2 labels Oct 26, 2017
@pamil pamil added this to the 1.0 milestone Oct 26, 2017
@pamil pamil self-assigned this Oct 26, 2017
@stefandoorn
Copy link
Contributor

Nice! 👍

@pamil pamil merged commit 1b976ba into Sylius:1.0 Oct 27, 2017
@pamil pamil deleted the 1.0-php-7.2 branch October 27, 2017 08:13
@pamil pamil mentioned this pull request Nov 9, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zales0123 Zales0123 Zales0123 approved these changes

Assignees

@pamil pamil

Labels
Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pamil @stefandoorn @Zales0123