Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved parse alias exception message #8924

Merged
merged 2 commits into from
Nov 10, 2017
Merged

Improved parse alias exception message #8924

merged 2 commits into from
Nov 10, 2017

Conversation

11mb
Copy link
Contributor

@11mb 11mb commented Nov 1, 2017

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets none
License MIT

Small contribution to make the exception thrown in the Metadata resource more explanatory. When an Exception is thrown: "Invalid alias", the alias is now included in the Exception message, which makes debugging much easier.

@Zales0123 Zales0123 added the DX Issues and PRs aimed at improving Developer eXperience. label Nov 2, 2017
@pamil pamil changed the base branch from master to 1.0 November 6, 2017 13:49
@pamil pamil added this to the 1.0 milestone Nov 6, 2017
@pamil
Copy link
Contributor

pamil commented Nov 6, 2017

Needs to be rebased onto 1.0 branch, otherwise it's good to go! :)

@pamil pamil merged commit 919cf8d into Sylius:1.0 Nov 10, 2017
@pamil
Copy link
Contributor

pamil commented Nov 10, 2017

Thanks @11mb, welcome to the community! 🎉

@11mb
Copy link
Contributor Author

11mb commented Nov 10, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DX Issues and PRs aimed at improving Developer eXperience.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants