[Documenation] Turn off bundles fixes #9023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
lchrusciel
commented
Dec 13, 2017
lchrusciel
commented
| Q | A |
|---|---|
| Branch? | 1.0 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | |
| License | MIT |
lchrusciel
force-pushed
the
turning-off-bundles
branch
from
5555cc6
to
198de90
Compare
CoderMaggie
added
the
Documentation
pamil
reviewed
Dec 18, 2017
| @@ -52,13 +52,16 @@ The part that has to be removed from this file is shown below: | |||
|
|
|||
| .. code-block:: yaml | |||
|
|
|||
| parameters: | |||
| # sylius.security.shop_regex: "^/(?!admin|api/.*|api$)[^/]++" | |||
There was a problem hiding this comment.
Is it a valid YAML syntax?
parameters:
# nothing here
security:
# ...
There was a problem hiding this comment.
Probably something can go wrong with that :/
Zales0123
reviewed
Dec 19, 2017
| @@ -82,6 +87,18 @@ The part that has to be removed from this file is shown below: | |||
| # success_handler: sylius.handler.shop_user_logout | |||
| # anonymous: true | |||
|
|
|||
| access_control: | |||
There was a problem hiding this comment.
I think the same here, and for security.firewalls I think they all should have ~ at the end... @lchrusciel could you check that?
|
I just commented the lines that should be removed. In each of the sections, there are a few more configurations, and I didn't want to copy and paste the whole security setup because it is too verbose for these examples. /cc @pamil @Zales0123 |
pamil
approved these changes
Dec 22, 2017
|
Thanks Łuki! 🌮 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.