Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] Fix customer order addresses saver #9036

Merged
merged 1 commit into from Dec 19, 2017
Merged

[Core] Fix customer order addresses saver #9036

merged 1 commit into from Dec 19, 2017

Conversation

GSadee
Copy link
Member

@GSadee GSadee commented Dec 18, 2017

Q A
Branch? 1.0
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

Because both shippingAddress and billingAddress can be returned null.

@GSadee GSadee added the Potential Bug Potential bugs or bugfixes, that needs to be reproduced. label Dec 18, 2017
@pamil pamil added this to the 1.0 milestone Dec 18, 2017
@lchrusciel lchrusciel merged commit 4971b0d into Sylius:1.0 Dec 19, 2017
@lchrusciel
Copy link
Member

Thanks Grzegorz! 🐋

@GSadee GSadee deleted the addresses-saver-fix branch December 19, 2017 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pamil pamil pamil approved these changes

@Zales0123 Zales0123 Zales0123 approved these changes

@lchrusciel lchrusciel lchrusciel approved these changes

Assignees
No one assigned
Labels
Potential Bug Potential bugs or bugfixes, that needs to be reproduced.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@GSadee @lchrusciel @pamil @Zales0123