Fixed Customer API docs with invalid "groups" parameter #9135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pamil
reviewed
Jan 30, 2018
| "group":[ | ||
|
|
||
| ] | ||
| "group":{} |
There was a problem hiding this comment.
Shouldn't it be "group":null or "group":"GROUP_CODE" then?
There was a problem hiding this comment.
That's the response given by the API right now
There was a problem hiding this comment.
Perhaps we are missing serialization definition of customer groups.
There was a problem hiding this comment.
That's the current behaviour that needs to be documented anyway :)
Zales0123
added
Documentation
pamil
force-pushed
the
fix/customer-api-docs
branch
from
a6cce71
to
c13e455
Compare
|
Rebased & build restarted. |
pamil
approved these changes
Mar 9, 2018
|
Thanks Gorka! 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the Customer API docs, "groups" fields is expected to be an array while it has a 1 to N relationship in DB, and it does not work if an array is passed.