Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make images removal tests great again #9161

Merged
merged 1 commit into from
Feb 7, 2018
Merged

Conversation

pamil
Copy link
Contributor

@pamil pamil commented Feb 7, 2018

There were lots of failures because the saved image URL was a data URI.

@pamil pamil self-assigned this Feb 7, 2018
@pamil pamil added Maintenance CI configurations, READMEs, releases, etc. Behat Issues and PRs aimed at improving Behat usage. labels Feb 7, 2018
@pamil pamil added this to the 1.0 milestone Feb 7, 2018
@@ -94,12 +94,16 @@ public function isImageWithTypeDisplayed($type)
{
$imageElement = $this->getImageElementByType($type);

var_dump($imageElement ? $imageElement->find('css', 'img')->getAttribute('src') : 'null');
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Debugging JS ain't easy 🌮

@pamil pamil merged commit ac66ca4 into Sylius:1.0 Feb 7, 2018
@pamil pamil deleted the 1.0-reliable-behat branch February 7, 2018 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Behat Issues and PRs aimed at improving Behat usage. Maintenance CI configurations, READMEs, releases, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant