Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation] Customizing Factory #9176

Merged
merged 1 commit into from
Mar 9, 2018
Merged

[Documentation] Customizing Factory #9176

merged 1 commit into from
Mar 9, 2018

Conversation

GitProdEnv
Copy link
Contributor

Q A
Branch? 1.0
Bug fix? yes
New feature? no
BC breaks? no/yes
Deprecations? no
Related tickets fixes #X, partially #Y, mentioned in #Z
License MIT

Additionally added, more extensive documentation. Assures that the routing points to /admin, and that the simple product page is overwritten.

Additionally bug fixing. Now we are really pointing to the simple page, instead of pointing to the configurable product page.

9a99d2b

@GitProdEnv GitProdEnv changed the title Patch 2 [Documentation] Customizing Factory Feb 9, 2018
@Zales0123 Zales0123 added the Documentation Documentation related issues and PRs - requests, fixes, proposals. label Feb 11, 2018
Copy link
Member

@CoderMaggie CoderMaggie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've got far too many commits in this PR ;) Please squash them 🙏 .

@@ -125,6 +126,23 @@ You can for example override ``sylius_admin_product_create_simple`` route like b
form: SyliusAdminBundle:Product:_form.html.twig
route:
name: sylius_admin_product_create_simple

Create a new yaml file located at ``app/config/routing/admin.yml``, if it not already exists.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...if it does not exists yet.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...if it does not exist yet. 🎉

Additionally added documentation (more information). Assures that the routing points to /admin, and that the simple product page is overwritten.
Additionally bug fixing. Now we are really pointing to the simple page, instead of pointing to the configurable product page.
@CoderMaggie
Copy link
Member

@pamil the base branch is probably wrong here?

@pamil pamil changed the base branch from master to 1.0 March 9, 2018 12:45
@pamil
Copy link
Contributor

pamil commented Mar 9, 2018

@CoderMaggie good point! 👍

@pamil pamil merged commit 7ef78f4 into Sylius:1.0 Mar 9, 2018
@pamil
Copy link
Contributor

pamil commented Mar 9, 2018

Thanks @GitProdEnv! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Documentation related issues and PRs - requests, fixes, proposals.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants