[ResourceBundle] Add the controller tag #9185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dragosprotung
changed the title
|
I am not sure why the tests are failing, but i think they are not related |
|
Rebasing this PR with the most recent |
dragosprotung
force-pushed
the
controller_tag
branch
from
ea7b7cd
to
bd54a0c
Compare
|
Rebased but with no luck. at least the application suite now passed |
dragosprotung
force-pushed
the
controller_tag
branch
from
bd54a0c
to
74df630
Compare
|
Rebased it to the newest |
|
Oopsie. |
pamil
approved these changes
Mar 9, 2018
|
Thank you Dragos! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resource controllers have the tag missing. This does not allow having dependencies injected into actions.