Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation][GridBundle]Wrong definition of sortable attribute #9195

Merged
merged 1 commit into from Feb 26, 2018

Conversation

Mipme
Copy link
Contributor

@Mipme Mipme commented Feb 15, 2018

sortable: true --> translates to o.1 in the SQL query
sortable: ~ --> translates to o.attribute in SQL query
sortable: path.to.my.subentity.prop --> translates to o.subentity.prop

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets fixes none
License MIT

@Zales0123 Zales0123 added the Documentation Documentation related issues and PRs - requests, fixes, proposals. label Feb 15, 2018
@CoderMaggie
Copy link
Member

Good catch @Mipme ! Can you please rebase your PR with the 1.0 branch? I have changed the base branch of this PR for you, as it is a fix of existing docs. :)

@CoderMaggie CoderMaggie changed the base branch from master to 1.0 February 22, 2018 07:04
@CoderMaggie CoderMaggie reopened this Feb 22, 2018
sortable: true --> translates to o.1 in the SQL query
sortable: ~ --> translates to o.attribute in SQL query
sortable: path.to.my.subentity.prop --> translates to o.subentity.prop
@pamil
Copy link
Contributor

pamil commented Feb 26, 2018

Thanks @Mipme! 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Documentation related issues and PRs - requests, fixes, proposals.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants