Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix select province in checkout address #9237

Merged
merged 2 commits into from
Mar 8, 2018
Merged

Fix select province in checkout address #9237

merged 2 commits into from
Mar 8, 2018

Conversation

serieznyi
Copy link
Contributor

@serieznyi serieznyi commented Mar 8, 2018 •
edited
Loading

Q A
Branch? 1.0
Bug fix? yes
New feature? no
BC breaks? no/yes
Deprecations? no
Related tickets fixes #8330
License MIT

Before changes
https://drive.google.com/open?id=1ddyaMFtmW0M3oXX1JrfV8HuTvlk1jFY4

After changes
https://drive.google.com/open?id=1quA3mWzYAUoikCnTQLvgW0PBrLuHWaJH

Maybe not a best solution, but it`s work

Also it is work for billing address

@pamil pamil added this to the 1.0 milestone Mar 8, 2018
@pamil pamil added Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). Potential Bug Potential bugs or bugfixes, that needs to be reproduced. and removed Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). labels Mar 8, 2018
@pamil pamil merged commit d2a2e0c into Sylius:1.0 Mar 8, 2018
@pamil
Copy link
Contributor

pamil commented Mar 8, 2018

Thank you Maxim! 🥇

@serieznyi serieznyi deleted the issue-8330-fix-dynamic-select branch March 8, 2018 17:47
@Zales0123 Zales0123 mentioned this pull request Mar 1, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pamil pamil pamil approved these changes

Assignees
No one assigned
Labels
Potential Bug Potential bugs or bugfixes, that needs to be reproduced.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@serieznyi @pamil