Moved debug toggle from AppKernel to web/app_dev.php #929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ah yes, now I know why all times were "false" according to my php.ini. Thanks. |
|
@Im0rtality #513, is actualized quite often, it's just merged into first commit, so it's showing date "3 months ago" |
stloyd
added a commit
that referenced
this pull request
Jan 29, 2014
Moved debug toggle from AppKernel to web/app_dev.php
|
Merged, thanks! Will adjust to cover this changes in mentioned PR. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AppKernel->init()was using deprecated classes and was duplicating code and is deprecated itself altogether. So moved code to where it belongs - app_dev.php.https://github.com/symfony/symfony-standard/blob/master/app/AppKernel.php
https://github.com/symfony/symfony-standard/blob/master/web/app_dev.php
Also removed
ini_set('date.time', 'UTC');as should be already set in php.ini depending on server location (plus we have that set in puppet script):https://github.com/Im0rtality/Sylius/blob/master/vagrant/manifests/default.pp#L118
Solves some SensioInsight major warnings.
This partially overlaps with #513, but last commit was 3 months ago.