Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor doc fix #9314

Merged
merged 1 commit into from
Apr 10, 2018
Merged

Minor doc fix #9314

merged 1 commit into from
Apr 10, 2018

Conversation

cedricziel
Copy link
Contributor

Q A
Branch? 1.0, 1.1 or master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets -
License MIT

@cedricziel
Copy link
Contributor Author

Is my change targeting the correct branch?

@Zales0123 Zales0123 added the Documentation Documentation related issues and PRs - requests, fixes, proposals. label Apr 8, 2018
@CoderMaggie
Copy link
Member

Hi @cedricziel 👋 ! Great to have you there in the Sylius community! Your changes in all your PRs (this one, #9315 and #9316) should target the 1.0 branch, could you please rebase to this branch in all these PRs? I will change the target branch for you. Thanks in advance! 💪

@CoderMaggie CoderMaggie changed the base branch from master to 1.0 April 9, 2018 09:50
@cedricziel
Copy link
Contributor Author

Rebased the commit.

@pamil pamil merged commit 4174112 into Sylius:1.0 Apr 10, 2018
@pamil
Copy link
Contributor

pamil commented Apr 10, 2018

Thanks! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Documentation related issues and PRs - requests, fixes, proposals.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants