Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Grid] Default parameters for "default" grid action #9349

Merged

Conversation

Zales0123
Copy link
Member

Q A
Branch? 1.0
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

With previous implementation, it was required to pass parameters even if action route does not require any:

actions:
    main:
        destroy_ring:
            type: default
            options:
                link:
                    route: sylius_destroy_ring
                    parameters: {}

Now not passing paremeters does not result in twig error.

actions:
    main:
        destroy_ring:
            type: default
            options:
                link:
                    route: sylius_destroy_ring

@Zales0123 Zales0123 added the Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). label Apr 18, 2018
@pamil pamil merged commit a1e9694 into Sylius:1.0 Apr 19, 2018
@pamil
Copy link
Contributor

pamil commented Apr 19, 2018

Thanks, Mateusz 🎉

@Zales0123 Zales0123 deleted the default-parameters-for-grid-default-action-route branch April 19, 2018 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants