Update node-sass for compatibility with Node.js 10 #9404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: gulp-sass v4.0.0 dropped support for old Node.js versions. If that's not fine for us, we could perhaps stick to gulp-sass v3.2.1 for now. But it's probably not worth it to maintain compatibility with unsupported old Node versions: https://github.com/nodejs/Release#release-schedule |
pamil
approved these changes
May 16, 2018
|
I'd say we have the same policy as for PHP - supporting only officially supported versions, so I'm fine with that. |
|
Thank you, Teoh! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node.js 10 compatibility was introduced in node-sass v4.9.0