Improve use of Semantic's cards in frontend #9487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lchrusciel
approved these changes
Jun 13, 2018
|
Tests are sorted. |
lchrusciel
approved these changes
Jun 14, 2018
Zales0123
approved these changes
Jun 14, 2018
|
Thanks Michael! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small improvement to how Semantic UI's cards are rendered with the ShopBundle's default layouts. Right now they're used within
.ui.gridcontainers, but a.ui.cardscontainer can also be used as a grid and handles rendering a little better overall (especially with ensuring the cards are equal heights, see below screenshots).Current demo homepage:
Homepage with patch:
