Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[minor] SCA #9539

Merged
merged 1 commit into from Jul 2, 2018
Merged

[minor] SCA #9539

merged 1 commit into from Jul 2, 2018

Conversation

kalessil
Copy link
Contributor

@kalessil kalessil commented Jul 1, 2018

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets n/a
License MIT

Php Inspections (EA Ultimate): new findings

@kalessil kalessil changed the title Php Inspections (EA Ultimate): minor code tweaks [minor] SCA Jul 1, 2018
@pamil pamil changed the base branch from master to 1.1 July 1, 2018 16:35
@pamil pamil added Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). Maintenance CI configurations, READMEs, releases, etc. labels Jul 1, 2018
@kalessil
Copy link
Contributor Author

kalessil commented Jul 1, 2018

One of travis build envs has errored - not connected with the changes.

@Zales0123
Copy link
Member

Indeed, the fail is not related to changes. Could you please rebase the PR with 1.1 branch? Maybe that would help

@kalessil
Copy link
Contributor Author

kalessil commented Jul 2, 2018

@Zales0123 : will do later today.

@pamil pamil closed this Jul 2, 2018
@pamil pamil reopened this Jul 2, 2018
@pamil
Copy link
Contributor

pamil commented Jul 2, 2018

Travis build should be fine now 🎉

@kalessil
Copy link
Contributor Author

kalessil commented Jul 2, 2018

@pamil : worked, huge thank you!

@pamil pamil merged commit de21e24 into Sylius:1.1 Jul 2, 2018
@pamil
Copy link
Contributor

pamil commented Jul 2, 2018

Thank you, Vladimir! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pamil pamil pamil approved these changes

@Zales0123 Zales0123 Zales0123 approved these changes

@CoderMaggie CoderMaggie CoderMaggie approved these changes

Assignees
No one assigned
Labels
Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). Maintenance CI configurations, READMEs, releases, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kalessil @Zales0123 @pamil @CoderMaggie