Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHPSpec version not specified in docs #9724

Merged
merged 1 commit into from Sep 24, 2018
Merged

PHPSpec version not specified in docs #9724

merged 1 commit into from Sep 24, 2018

Conversation

Zales0123
Copy link
Member

Q A
Branch? 1.1
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets fixes #9499
License MIT

That was a tough one 馃槃

@Zales0123 Zales0123 added the Documentation Documentation related issues and PRs - requests, fixes, proposals. label Sep 23, 2018
lchrusciel
lchrusciel approved these changes Sep 24, 2018
View reviewed changes
Copy link
Member

@lchrusciel lchrusciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's brilliant!

@lchrusciel lchrusciel changed the base branch from master to 1.1 September 24, 2018 07:42
@lchrusciel lchrusciel merged commit 6bfb07a into Sylius:1.1 Sep 24, 2018
@lchrusciel
Copy link
Member

Thanks Mati! 馃悑

@Zales0123 Zales0123 deleted the phpspec2-documentation-mentions-removed branch September 24, 2018 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lchrusciel lchrusciel lchrusciel approved these changes

Assignees
No one assigned
Labels
Documentation Documentation related issues and PRs - requests, fixes, proposals.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Zales0123 @lchrusciel