Add checks for security context so that layout is usable for 404 error page. #974
Conversation
| @@ -64,7 +64,7 @@ public function setCurrency($currency) | |||
|
|
|||
| protected function getUser() | |||
| { | |||
| if ($this->securityContext->isGranted('IS_AUTHENTICATED_REMEMBERED')) { | |||
| if ($this->securityContext->getToken() && $this->securityContext->isGranted('IS_AUTHENTICATED_REMEMBERED')) { | |||
There was a problem hiding this comment.
This is wrong, it should work with old code, if not there is bug in Symfony that broke BC compatibility.
There was a problem hiding this comment.
It works under normal conditions, but not in 404 pages. Check out the SF doc here: http://symfony.com/doc/current/cookbook/controller/error_pages.html (second gray box).
There was a problem hiding this comment.
You must not use is_granted in your error pages (or layout used by your error pages), because the router runs before the firewall. If the router throws an exception (for instance, when the route does not match), then using is_granted will throw a further exception. You can use is_granted safely by saying {% if app.user and is_granted('...') %}.
?
If so, then you get this wrong, because it's only about calling that in Twig, not in code it self.
There was a problem hiding this comment.
Obviously the twig code is just an extension wrapper for the security check behind it. I'm sure you understand the intention of the documentation beyond its literal text..
There was a problem hiding this comment.
SecurityContext throws a further exception if there's no token and you call isGranted(). The docs are only speaking about Twig, because the page is about customzing the Twig error templates. But it applies fot the code too 🐤
|
👍 |
Add checks for security context so that layout is usable for 404 error page.
|
Thank you Daniel! |
| <h2>The server returned a "404 Not Found".</h2> | ||
|
|
||
| <div> | ||
| Something is broken. Please e-mail us at [email] and let us know |
There was a problem hiding this comment.
Yeah, true. I just copied the twig default template up, but good point.
Also adding a 404 error page which extends the Sylius layout.