Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checkout and onhold OrderShippingState #981

Merged
merged 1 commit into from
Feb 5, 2014

Conversation

winzou
Copy link
Contributor

@winzou winzou commented Feb 5, 2014

There were 2 states missing

pjedrzejewski pushed a commit that referenced this pull request Feb 5, 2014
Add checkout and onhold OrderShippingState
@pjedrzejewski pjedrzejewski merged commit a70d5a0 into Sylius:master Feb 5, 2014
@pjedrzejewski
Copy link
Member

Thank you Alexandre!

@winzou winzou deleted the fix/state branch February 5, 2014 09:23
@stloyd stloyd added this to the 1.0.0-BETA1 milestone Feb 5, 2014
@Richtermeister
Copy link
Contributor

@pjedrzejewski @winzou Just curious, what is the difference between shipped and dispatched?

@kayue
Copy link
Contributor

kayue commented Feb 11, 2014

@Richtermeister @pjedrzejewski Shipment state "Pending" and "Dispatched" is not being used in anywhere, should we consider remove it?

@pjedrzejewski
Copy link
Member

Yes, I think we can remove dispatched. (I wanted to separate shipped from dispatched, but let's keep it simple, we can still do this later if needed)

@Richtermeister
Copy link
Contributor

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants