Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle taxon permalink generation #990

Merged
merged 3 commits into from
Feb 5, 2014
Merged

Conversation

lbaey
Copy link
Contributor

@lbaey lbaey commented Feb 5, 2014

using TreeSlugHandler seemed a good way to do it.
what do you think ?

using gedmo TreeSlugHandler
It is now defined in TaxonomiesBundle
@stloyd stloyd added RFC labels Feb 5, 2014
@pjedrzejewski
Copy link
Member

Shame on me that I did not know about this, very nice! Let's wait for travis. :) Thank you @lbaey!

@Richtermeister
Copy link
Contributor

Oooh, very elegant! I guess this means the gedmo issue with extending the tree is solved now, too? Cool! :)

pjedrzejewski pushed a commit that referenced this pull request Feb 5, 2014
Handle taxon permalink generation
@pjedrzejewski pjedrzejewski merged commit 1dc86a3 into Sylius:master Feb 5, 2014
@pjedrzejewski
Copy link
Member

Thank you @lbaey, that is really useful!

@stloyd stloyd added this to the 1.0.0-BETA1 milestone Feb 5, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFC Discussions about potential changes or new features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants