Forgotten password fixes #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zales0123
force-pushed
the
forgotten-password-fixes
branch
from
b49dafd
to
52248d7
Compare
Zales0123
commented
Jul 19, 2022
| @@ -15,5 +15,4 @@ Feature: Preventing default administrator edition | |||
| And I save my changes | |||
| And I am logged in as "sylius@example.com" administrator | |||
| And I browse administrators | |||
| Then I should be notified that I cannot edit Administrator of Sylius Demo | |||
There was a problem hiding this comment.
Adding flashes in one of the last changed on 1.12 branch revealed a hidden issue in Behats, that after blocked edition the administrator is logged out anyway 🤯 I've removed the problematic step for now (we have a check for the result below anyway) but it probably should be investigated 🖖
GSadee
approved these changes
Jul 20, 2022
|
Thanks, Mateusz! 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes needed after Sylius/Sylius#14138
/admin/forgotten-passwordURL anonymouslyBefore:
After: