Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Google Analytics code to Sylius Demo #83

Closed
wants to merge 1 commit into from
Closed

Add Google Analytics code to Sylius Demo #83

wants to merge 1 commit into from

Conversation

CoderMaggie
Copy link
Member

No description provided.

@CoderMaggie CoderMaggie requested a review from a team as a code owner October 4, 2019 12:47
@stefandoorn
Copy link
Contributor

I would suggest adding Google Tag Manager & then load Analytics via GTM. It allows it to later on add other things more easily if you want. (eg a feedback popup or whatever).

@CoderMaggie CoderMaggie closed this Oct 8, 2019
@GSadee GSadee mentioned this pull request Oct 8, 2019
Merged
@pamil pamil deleted the CoderMaggie-analytics-1 branch October 8, 2019 11:55
pamil added a commit that referenced this pull request Oct 8, 2019
@pamil
minor #85 Add Google Analytics code (CoderMaggie)
2c17d26 
This PR was merged into the 1.6-dev branch.

Discussion
----------

Replaces #83

Commits
-------

c6dc72c Add Google Analytics code to Sylius Demo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pamil pamil pamil approved these changes

@kulczy kulczy kulczy approved these changes

@Tomanhez Tomanhez Tomanhez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@CoderMaggie @stefandoorn @pamil @kulczy @Tomanhez