Debug Sylius Mailer command #223
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lchrusciel
force-pushed
the
debug-sylius-mailer-command
branch
from
3caab76
to
8e56506
Compare
lchrusciel
force-pushed
the
debug-sylius-mailer-command
branch
14 times, most recently
from
bc26212
to
05c9ae4
Compare
lchrusciel
force-pushed
the
debug-sylius-mailer-command
branch
from
05c9ae4
to
0383dc0
Compare
oallain
reviewed
Mar 5, 2024
Co-authored-by: Olivier ALLAIN <oallain@users.noreply.github.com>
NoResponseMate
approved these changes
Apr 9, 2024
Comment on lines
+13
to
+16
| <directory>./src/Bundle/tests/</directory> | ||
|
|
||
| <exclude>./src/Bundle/tests/Integration/Cli/</exclude> | ||
| </testsuite> |
There was a problem hiding this comment.
Suggested change
| <directory>./src/Bundle/tests/</directory> | |
| <exclude>./src/Bundle/tests/Integration/Cli/</exclude> | |
| </testsuite> | |
| <directory>./src/Bundle/tests/</directory> | |
| <exclude>./src/Bundle/tests/Integration/Cli/</exclude> | |
| </testsuite> |
Zales0123
approved these changes
May 8, 2024
| $dumper->dump($input, $output); | ||
| } | ||
|
|
||
| return 0; |
Comment on lines
+43
to
+47
| foreach ($this->dumpers as $dumper) { | ||
| $dumper->dump($input, $output); | ||
| } | ||
|
|
||
| return 0; |
There was a problem hiding this comment.
What would you say for extracting it to the $this->dumpAllEmails function? And $this->dumpEmailDetails below? we would have a nice 5-lines long execute function here 🚀
| /* | ||
| * This file is part of the Sylius package. | ||
| * | ||
| * (c) Paweł Jędrzejewski |
There was a problem hiding this comment.
Should be changed and will be after merging #233 👌
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated version of #201
I was playing with SyliusMailerBundle a little bit yesterday and wanted to get information about emails that are configured. As it is a project using Sylius with some customizations, my first thought was "so what, I'm gonna browse yaml files like some kind of animal?!". My second thought was "but I can use
debug:config sylius_mailercommand to dump the bundle configuration which did the trick but looked rough and ugly.So my final resolution was - what if we have a nice debug command for the configured emails? And I wrote it. There are obviously a lot of things to improve (I still don't know if dumping the email template brings any value 🤷♂️), but looks nicer 🚀
Let me know what you think about it 🫡
PS. Thanks @loic425 for the inspiration with debug serializer command - I definitely belive following the "it's useful for me, maybe it's useful for others" path is a good idea 🖖