Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for Symfony 7 #840

Closed
wants to merge 5 commits into from
Closed

Conversation

loic425
Copy link
Member

@loic425 loic425 commented Jan 19, 2024

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

@loic425 loic425 requested a review from a team as a code owner January 19, 2024 15:26
Copy link
Member

@diimpp diimpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will it be alright to give resource-bundle sf7 support in 0.x.x branch since sylius/sylius will only have it at 2.0?

@oallain
Copy link
Member

oallain commented Jan 19, 2024

We need to wait winzou/state-machine#58 😉

@loic425 loic425 mentioned this pull request Jan 23, 2024
69 tasks
@loic425
Copy link
Member Author

loic425 commented Jan 23, 2024

Will it be alright to give resource-bundle sf7 support in 0.x.x branch since sylius/sylius will only have it at 2.0?

sylius/sylius and sylius/resource are not synchronized together and i'ts technically possible to add that support on resource 1.x area. Moreover Sylius 2.0 will use sylius resource 1.x... Sylius resource 2.x will need to remove old metadata system and resource controller at some point.

@loic425 loic425 force-pushed the symfony-7 branch 2 times, most recently from 4ee74ef to 1ea0d1e Compare February 2, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants