[SF7] Remove enable authenticator manager option on test application #881
Conversation
loic425
force-pushed
the
sf7/remove-enable-authentication-manager
branch
5 times, most recently
from
9c6dade
to
0e8beb3
Compare
loic425
force-pushed
the
sf7/remove-enable-authentication-manager
branch
from
0e8beb3
to
3f97214
Compare
loic425
force-pushed
the
sf7/remove-enable-authentication-manager
branch
from
3f97214
to
1f19c88
Compare
loic425
force-pushed
the
sf7/remove-enable-authentication-manager
branch
from
1f19c88
to
f27f93b
Compare
| "sylius-labs/coding-standard": "^4.0", | ||
| "sylius/grid-bundle": "^1.7 || dev-symfony-7", | ||
| "symfony/console": "^5.4 || ^6.4 || ^7.0", | ||
| "symfony/dependency-injection": "^5.4 || ^6.4 || ^7.0", | ||
| "symfony/dotenv": "^5.4 || ^6.4 || ^7.0", | ||
| "symfony/http-kernel": "^5.4 || ^6.4 || ^7.0", |
There was a problem hiding this comment.
this is the only one dependency I've added on dev requirements, the others are just moved up or down.
There was a problem hiding this comment.
normally this kind of things is already ok if we use Docker or CI to set up the dev requirements.
If you don't use docker it will not use the "symfony requirement from Flex" filter if we don't have flex on composer globals.
There was a problem hiding this comment.
but I think it's better to explicit all our dev dependencies.
| @@ -70,20 +70,21 @@ | |||
| "phpstan/phpstan-phpunit": "^1.1", | |||
| "phpstan/phpstan-webmozart-assert": "^1.2", | |||
| "phpunit/phpunit": "^9.5", | |||
| "rector/rector": "^0.18.2", | |||
There was a problem hiding this comment.
Should it depend on https://github.com/Sylius/SyliusRector instead? Then explicit rector/rector requirement is not needed anymore.
I'm not fully sure why syliusrector exists though.
There was a problem hiding this comment.
hum sylius rector was exists to add some custom rules to bump Sylius e-commerce versions. But I think it's not used anymore.
Based on #885
Before
