Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secure checkout complete action #365

Merged
merged 14 commits into from
Jan 4, 2019
Merged

Conversation

lchrusciel
Copy link
Member

@lchrusciel lchrusciel commented Jan 3, 2019

This PR contains the improved implementation of #351. Current implementation will support following scenarios:

  1. User is logged in - valid
  2. User is not logged in and customer exists, but doesn't have an account - valid
  3. User is logged in and customer exists and they are related - valid
  4. User is not logged in and customer exists, but has an account - exception, he needs to log in
  5. User is logged in but different mail is provided - exception

@lchrusciel
Copy link
Member Author

/cc @mamazu

Will it work for you?

@mamazu
Copy link
Member

mamazu commented Jan 3, 2019

Thanks for picking up the work.

src/Exception/WrongUserException.php Outdated Show resolved Hide resolved
src/Exception/WrongUserException.php Outdated Show resolved Hide resolved
@Zales0123 Zales0123 merged commit 0b18c2e into Sylius:master Jan 4, 2019
@Zales0123
Copy link
Member

Thanks, Łukasz! 🥇

@lchrusciel
Copy link
Member Author

And Maximilian!

@lchrusciel lchrusciel deleted the checkout_bug branch January 4, 2019 14:34
@Zales0123
Copy link
Member

And Maximilian! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants