add validation to verify account action and update swagger.yml #555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mamazu
reviewed
Sep 22, 2019
spec/Validator/Customer/VerificationTokenExistsValidatorSpec.php
Outdated
Show resolved
Hide resolved
spec/Validator/Customer/VerificationTokenExistsValidatorSpec.php
Outdated
Show resolved
Hide resolved
|
|
||
| namespace Sylius\ShopApiPlugin\Validator\Customer; | ||
|
|
||
| use Sylius\Component\User\Repository\UserRepositoryInterface; |
There was a problem hiding this comment.
Please use the interface from the core.
There was a problem hiding this comment.
There is only this interface. Do you mean the class?
There was a problem hiding this comment.
We should use a core interface
There was a problem hiding this comment.
I don't know which one you mean. The UserRepositoryInterface from the user component is the only one, I have found.
lchrusciel
reviewed
Sep 22, 2019
Co-Authored-By: Łukasz Chruściel <lchrusciel@gmail.com>
lchrusciel
approved these changes
Sep 22, 2019
|
Thank you, @CSchulz! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.