Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to Bootstrap 5 #122

Merged
merged 48 commits into from
Jan 15, 2024
Merged

Conversation

RadnoK
Copy link
Contributor

@RadnoK RadnoK commented Dec 30, 2023

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? yes
Deprecations? yes
Related tickets -
License MIT

Introducing Bootstrap 5 with an overhaul of the UI 🚀

Amazing work from @mycreedo includes:

  • Update to Bootstrap 5 🙌
  • No more legacy_mode
  • Simple installation
  • Improved Webpack config
  • Cleanup of dependencies
  • Refreshed UI styles on all pages

tests/Application also now is based on Sylius 1.12 and has a full working configuration of app based on SyliusBoostrapTheme.

Caution

Theme is not only compatible with Sylius 1.12. Support for older versions has been dropped and the theme now features all the latest Sylius features.

Some photos

homepage-preview

product-promotions

cart-preview

checkout-4

user-order-history

@oallain oallain added the enhancement New feature or request label Dec 31, 2023
@oallain oallain self-assigned this Dec 31, 2023
@oallain
Copy link
Member

oallain commented Dec 31, 2023

Hello,
Don't be afraid of the failed CI, it's not up to date.

@oallain oallain linked an issue Jan 5, 2024 that may be closed by this pull request
@oallain oallain force-pushed the migration-to-bs5 branch 6 times, most recently from e26df29 to ed3fcd2 Compare January 6, 2024 17:07
@oallain
Copy link
Member

oallain commented Jan 6, 2024

Hello @mycreedo and @RadnoK

I had some commit to :

  • Added and fixed TwigCS
  • Added and fixed ESLint
  • Added PHPUnit and write some tests
  • Added execution of previous checks in Github Actions.
  • Update Readme

I think that'll help for the future.

@oallain oallain merged commit bc0ae8c into SyliusCrafts:master Jan 15, 2024
2 checks passed
@oallain oallain deleted the migration-to-bs5 branch January 15, 2024 19:15
@oallain oallain mentioned this pull request Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to Bootstrap 5
4 participants