Move the semicolon to the new line for chained calls #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lchrusciel
reviewed
Apr 20, 2022
coldic3
force-pushed
the
feature/chained-calls-semicolon
branch
3 times, most recently
from
2ee8bdf
to
e3724ba
Compare
coldic3
force-pushed
the
feature/chained-calls-semicolon
branch
from
e3724ba
to
33c8a1e
Compare
|
@lchrusciel Done 🙂 |
GSadee
approved these changes
Apr 21, 2022
|
Thanks, Kevin! 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I see moving semicolons to the new line for chained calls is a part of Sylius' coding convention so it would be great to have it in our
ecs.phpfile.