Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uniform results data #103

Merged
merged 8 commits into from
May 14, 2020

Conversation

acomodi
Copy link
Contributor

@acomodi acomodi commented May 6, 2020

This PR makes results more uniform and creates a true DataFrame that can be queried to extract information on the runs.

@acomodi
Copy link
Contributor Author

acomodi commented May 7, 2020

@HackerFoo @litghost @mithro FYI. This is the colab page that uses the dataframe produced with this PR.

@acomodi acomodi requested review from kgugala and mithro and removed request for kgugala May 14, 2020 09:41
Copy link
Member

@kgugala kgugala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good in general, please add license header

dataframe.py Show resolved Hide resolved
symbiflow.py Outdated Show resolved Hide resolved
@acomodi acomodi requested a review from kgugala May 14, 2020 09:58
@acomodi acomodi added the merge-if-green Merge pull request if the CI system goes green. label May 14, 2020
Copy link
Member

@kgugala kgugala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Alessandro Comodi <acomodi@antmicro.com>
Signed-off-by: Alessandro Comodi <acomodi@antmicro.com>
Signed-off-by: Alessandro Comodi <acomodi@antmicro.com>
Signed-off-by: Alessandro Comodi <acomodi@antmicro.com>
Signed-off-by: Alessandro Comodi <acomodi@antmicro.com>
Signed-off-by: Alessandro Comodi <acomodi@antmicro.com>
Signed-off-by: Alessandro Comodi <acomodi@antmicro.com>
Signed-off-by: Alessandro Comodi <acomodi@antmicro.com>
@symbiflow-robot symbiflow-robot merged commit c20e735 into chipsalliance:master May 14, 2020
@acomodi acomodi deleted the uniform-results-data branch May 14, 2020 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-if-green Merge pull request if the CI system goes green.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants