Add buttons_arty target #1006

duck2 · 2019-09-17T12:03:43Z

This adds an arty-swbut board(separate from arty, which uses uart harness) which uses the swbut harness of Arty, and adds a case to xc7/tests/buttons so that make buttons_arty_prog works on HW.

Signed-off-by: Fahrican Koşar <duck2@protonmail.com>

acomodi

LGTM apart from a minor change. Have you checked this correctly works on HW, right?

xc7/archs/artix7/devices/CMakeLists.txt

Signed-off-by: Fahrican Koşar <duck2@protonmail.com>

acomodi

LGTM. Let's wait for green CI

duck2 · 2019-09-18T07:40:35Z

LGTM apart from a minor change. Have you checked this correctly works on HW, right?

I even boasted to a friend about it, "look, this is without Vivado!" :P

duck2 · 2019-09-18T15:21:37Z

looks like it's about the rename

acomodi · 2019-09-18T15:24:13Z

@duck2 So, 7-series CI failed with this output:

FAILED: cd /tmpfs/src/github/symbiflow-arch-defs-presubmit-xc7/build/xc7/tests/counter/counter_arty-uart/artix7-xc7a50t-arty-uart-roi-virt-xc7a50t-arty-uart-test && /usr/bin/cmake -E env PYTHONPATH=/tmpfs/src/github/symbiflow-arch-defs-presubmit-xc7/utils /tmpfs/src/github/symbiflow-arch-defs-presubmit-xc7/build/env/conda/bin/python3 /tmpfs/src/github/symbiflow-arch-defs-presubmit-xc7/xc7/utils/prjxray_create_ioplace.py --map /tmpfs/src/github/symbiflow-arch-defs-presubmit-xc7/build/xc7/archs/artix7/devices/xc7a50t-arty-uart-roi-virt/synth_tiles_pinmap.csv --iostandard_defs /tmpfs/src/github/symbiflow-arch-defs-presubmit-xc7/build/xc7/tests/counter/counter_arty-uart/artix7-xc7a50t-arty-uart-roi-virt-xc7a50t-arty-uart-test/top.eblif.iostandard.json --blif /tmpfs/src/github/symbiflow-arch-defs-presubmit-xc7/build/xc7/tests/counter/counter_arty-uart/artix7-xc7a50t-arty-uart-roi-virt-xc7a50t-arty-uart-test/top.eblif --pcf /tmpfs/src/github/symbiflow-arch-defs-presubmit-xc7/build/xc7/tests/counter/arty-uart.pcf --out /tmpfs/src/github/symbiflow-arch-defs-presubmit-xc7/build/xc7/tests/counter/counter_arty-uart/artix7-xc7a50t-arty-uart-roi-virt-xc7a50t-arty-uart-test/top_io.place
usage: prjxray_create_ioplace.py [-h] --pcf PCF --blif BLIF --map MAP
                                 [--output OUTPUT]
                                 [--iostandard_defs IOSTANDARD_DEFS]
                                 [--iostandard IOSTANDARD] [--drive DRIVE]
prjxray_create_ioplace.py: error: argument --pcf/-p/-P: can't open '/tmpfs/src/github/symbiflow-arch-defs-presubmit-xc7/build/xc7/tests/counter/arty-uart.pcf': [Errno 2] No such file or directory: '/tmpfs/src/github/symbiflow-arch-defs-presubmit-xc7/build/xc7/tests/counter/arty-uart.pcf'
FAILED: cd /tmpfs/src/github/symbiflow-arch-defs-presubmit-xc7/build/xc7/tests/uart_loopback/uart_loopback_arty-uart/artix7-xc7a50t-arty-uart-roi-virt-xc7a50t-arty-uart-test && /usr/bin/cmake -E env PYTHONPATH=/tmpfs/src/github/symbiflow-arch-defs-presubmit-xc7/utils /tmpfs/src/github/symbiflow-arch-defs-presubmit-xc7/build/env/conda/bin/python3 /tmpfs/src/github/symbiflow-arch-defs-presubmit-xc7/xc7/utils/prjxray_create_ioplace.py --map /tmpfs/src/github/symbiflow-arch-defs-presubmit-xc7/build/xc7/archs/artix7/devices/xc7a50t-arty-uart-roi-virt/synth_tiles_pinmap.csv --iostandard_defs /tmpfs/src/github/symbiflow-arch-defs-presubmit-xc7/build/xc7/tests/uart_loopback/uart_loopback_arty-uart/artix7-xc7a50t-arty-uart-roi-virt-xc7a50t-arty-uart-test/top.eblif.iostandard.json --blif /tmpfs/src/github/symbiflow-arch-defs-presubmit-xc7/build/xc7/tests/uart_loopback/uart_loopback_arty-uart/artix7-xc7a50t-arty-uart-roi-virt-xc7a50t-arty-uart-test/top.eblif --pcf /tmpfs/src/github/symbiflow-arch-defs-presubmit-xc7/build/xc7/tests/uart_loopback/arty-uart.pcf --out /tmpfs/src/github/symbiflow-arch-defs-presubmit-xc7/build/xc7/tests/uart_loopback/uart_loopback_arty-uart/artix7-xc7a50t-arty-uart-roi-virt-xc7a50t-arty-uart-test/top_io.place
usage: prjxray_create_ioplace.py [-h] --pcf PCF --blif BLIF --map MAP
                                 [--output OUTPUT]
                                 [--iostandard_defs IOSTANDARD_DEFS]
                                 [--iostandard IOSTANDARD] [--drive DRIVE]
prjxray_create_ioplace.py: error: argument --pcf/-p/-P: can't open '/tmpfs/src/github/symbiflow-arch-defs-presubmit-xc7/build/xc7/tests/uart_loopback/arty-uart.pcf': [Errno 2] No such file or directory: '/tmpfs/src/github/symbiflow-arch-defs-presubmit-xc7/build/xc7/tests/uart_loopback/arty-uart.pcf'

try to run locally: make all_arty_bin and see what happens. Probably there is a missing pcf file due to the renaming of the arty-uart board definition.

litghost · 2019-09-18T17:02:42Z

looks like it's about the rename

Ya. This is caused because add_fpga_boards in this case used IMPLICIT_INPUT_IO_FILES (which I do not recommend). Either change the target to use the explicit INPUT_IO_FILES argument form or rename the pcf file.

Signed-off-by: Fahrican Koşar <duck2@protonmail.com>

duck2 · 2019-09-19T19:12:19Z

------- ------- ---------- ---------- ------- ---------- -------- ------- ------- ------ -------- --------- ------
      T Av Cost Av BB Cost Av TD Cost     CPD       sTNS     sWNS Ac Rate Std Dev  R lim Crit Exp Tot Moves  Alpha
------- ------- ---------- ---------- ------- ---------- -------- ------- ------- ------ -------- --------- ------
Warning 17: Starting t: 1 of 3 configurations accepted.
0.0e+00   0.617       0.25 2.3135e-09   2.693      -2.69   -2.693   0.250  0.0000  157.0     1.00          4   -nan
Error 1: timing_cost_check: 2.56216e-09 and timing_cost: 2.31354e-09 differ in check_place.
Error 2: 
Type: Placement
File: /tmp/really-really-really-really-really-really-really-really-really-really-really-really-really-long-path/conda/conda-bld/vtr_1568138554726/work/vpr/src/place/place.cpp
Line: 3555
Message: 
Completed placement consistency check, 1 errors found.
Aborting program.

What could cause this?

litghost · 2019-09-19T19:16:56Z

------- ------- ---------- ---------- ------- ---------- -------- ------- ------- ------ -------- --------- ------
      T Av Cost Av BB Cost Av TD Cost     CPD       sTNS     sWNS Ac Rate Std Dev  R lim Crit Exp Tot Moves  Alpha
------- ------- ---------- ---------- ------- ---------- -------- ------- ------- ------ -------- --------- ------
Warning 17: Starting t: 1 of 3 configurations accepted.
0.0e+00   0.617       0.25 2.3135e-09   2.693      -2.69   -2.693   0.250  0.0000  157.0     1.00          4   -nan
Error 1: timing_cost_check: 2.56216e-09 and timing_cost: 2.31354e-09 differ in check_place.
Error 2: 
Type: Placement
File: /tmp/really-really-really-really-really-really-really-really-really-really-really-really-really-long-path/conda/conda-bld/vtr_1568138554726/work/vpr/src/place/place.cpp
Line: 3555
Message: 
Completed placement consistency check, 1 errors found.
Aborting program.

What could cause this?

It's complaining about the incremental and full timing checks disagreeing by more than a certain amount. It likely means an ill-formed timing value somewhere. I haven't seen that particular problem in a while, and I'm surprised it cropped back up. For now let's just disable the error, assuming that the placer results are still reasonable.

acomodi · 2019-09-19T19:26:40Z

I would also create an issue to keep track of this error.

Signed-off-by: Fahrican Koşar <duck2@protonmail.com>

duck2 · 2019-09-24T06:15:34Z

Looks like I can build buttons_arty_bin with:

add_fpga_target(
  NAME buttons_arty
  BOARD arty-swbut
  SOURCES buttons_arty.v
  INPUT_IO_FILE arty.pcf
  )

but I can't build uart_loopback_arty_bin with:

add_fpga_target(
  NAME uart_loopback_arty
  BOARD arty-uart
  SOURCES uart_loopback.v
  INPUT_IO_FILE arty.pcf
  )

The build fails in xc7frames2bit missing its part_file argument.

Signed-off-by: Fahrican Koşar <duck2@protonmail.com>

…les/third_party/litex-boards-8830d15 build(deps): bump third_party/litex-boards from `575d681` to `8830d15`

probot-autolabeler bot added arch-artix7 lang-verilog Issue uses (or requires) Verilog language. labels Sep 17, 2019

add buttons_arty target

b4f1ab9

Signed-off-by: Fahrican Koşar <duck2@protonmail.com>

duck2 force-pushed the master branch from fe9c810 to b4f1ab9 Compare September 17, 2019 12:04

acomodi suggested changes Sep 17, 2019

View reviewed changes

xc7/archs/artix7/devices/CMakeLists.txt Outdated Show resolved Hide resolved

rename arty to arty-uart

ca2742b

Signed-off-by: Fahrican Koşar <duck2@protonmail.com>

acomodi approved these changes Sep 18, 2019

View reviewed changes

acomodi added the kokoro:force-run label Sep 18, 2019

kokoro-team removed the kokoro:force-run label Sep 18, 2019

fix arty rename

ab7df2d

Signed-off-by: Fahrican Koşar <duck2@protonmail.com>

acomodi added the kokoro:force-run label Sep 19, 2019

kokoro-team removed the kokoro:force-run label Sep 19, 2019

switch to add_fpga_target

b1e6015

Signed-off-by: Fahrican Koşar <duck2@protonmail.com>

acomodi added the kokoro:force-run label Sep 20, 2019

kokoro-team removed the kokoro:force-run label Sep 20, 2019

fully rename arty to arty-uart

f0609fe

Signed-off-by: Fahrican Koşar <duck2@protonmail.com>

acomodi added the kokoro:force-run label Sep 24, 2019

kokoro-team removed the kokoro:force-run label Sep 24, 2019

litghost merged commit d0f9e77 into f4pga:master Sep 24, 2019

duck2 mentioned this pull request Sep 25, 2019

Add buttons_arty target #998

Closed

duck2 mentioned this pull request Jul 15, 2020

Weird that we use Digilent Basys OpenOCD configuration with the Arty board #1594

Open

mkurc-ant pushed a commit to antmicro/f4pga-arch-defs that referenced this pull request May 30, 2022

Merge pull request f4pga#1006 from QuickLogic-Corp/dependabot/submodu…

dcdc6a1

…les/third_party/litex-boards-8830d15 build(deps): bump third_party/litex-boards from `575d681` to `8830d15`

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add buttons_arty target #1006

Add buttons_arty target #1006

duck2 commented Sep 17, 2019 •

edited

acomodi left a comment

acomodi left a comment

duck2 commented Sep 18, 2019

duck2 commented Sep 18, 2019

acomodi commented Sep 18, 2019

litghost commented Sep 18, 2019 •

edited

duck2 commented Sep 19, 2019

litghost commented Sep 19, 2019

acomodi commented Sep 19, 2019

duck2 commented Sep 24, 2019 •

edited

Add buttons_arty target #1006

Add buttons_arty target #1006

Conversation

duck2 commented Sep 17, 2019 • edited

acomodi left a comment

Choose a reason for hiding this comment

acomodi left a comment

Choose a reason for hiding this comment

duck2 commented Sep 18, 2019

duck2 commented Sep 18, 2019

acomodi commented Sep 18, 2019

litghost commented Sep 18, 2019 • edited

duck2 commented Sep 19, 2019

litghost commented Sep 19, 2019

acomodi commented Sep 19, 2019

duck2 commented Sep 24, 2019 • edited

duck2 commented Sep 17, 2019 •

edited

litghost commented Sep 18, 2019 •

edited

duck2 commented Sep 24, 2019 •

edited