Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to packages from 'litex-hub' channel #1795

Closed
wants to merge 2 commits into from

Conversation

tjurtsch
Copy link
Contributor

Most of the Conda dependencies are now provided via 'litex-hub' channel.

environment.yml Outdated
- symbiflow::iverilog
- symbiflow::icestorm
- symbiflow::capnproto-java
- litex-hub::symbiflow-yosys
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regardless of whether the packages come from symbiflow or litex-hub channel, removing version pinning right now will result in unstable builds. What is the plan to deal with incompatible packages? I'm specifically concerned with VTR and yosys packages, as those are the ones mostly likely to break.

@mithro
Copy link
Contributor

mithro commented Nov 20, 2020

@PiotrZierhoffer - I think we need the version pinning process here (and auto rolling bot).

@ajelinski
Copy link
Contributor

@litghost @mithro All litex-conda-*-based packages have been pinned to their latest versions available in the litex-hub channel. Being the latest ones most of those versions must've been tested in the previous CI of this PR so I hope this would be successful too.

symbiflow channel has been removed because currently all packages defaults channel lacks are taken from the litex-hub channel. I also rebased commits on top of the current master.

@ajelinski
Copy link
Contributor

ajelinski commented Nov 25, 2020

@mithro @litghost are you able to restart Documentation and Architecture Definitions tests alone? AD failed only because the Documentation had failed and it seems the root cause was some random Conda issue:

CondaHTTPError: HTTP 000 CONNECTION FAILED for url <https://repo.anaconda.com/pkgs/main/linux-64/repodata.json>
Elapsed: -

An HTTP error occurred when trying to retrieve this URL.
HTTP errors are often intermittent, and a simple retry will get you on your way.

Signed-off-by: Tomasz Jurtsch <tjurtsch@antmicro.com>
Signed-off-by: Tomasz Jurtsch <tjurtsch@antmicro.com>
@ajelinski
Copy link
Contributor

ajelinski commented Nov 26, 2020

The branch was rebased again because theconflict on symbiflow-vtr version appeared and it needed to be resolved.

The symbiflow-vtr basically stays the same after the change because it was built using the latest d6d69ff commit. It will be just taken from the litex-hub channel.

Copy link
Contributor

@litghost litghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the move to litex-hub, how are changes to packages introduced? What is the new process? For example, what does SymbiFlow/conda-packages#143 look like?

Also the litex-hub packages are only built with python 3.7, and the packages from SymbiFlow/conda-packages are only built with python 3.8. Should the litex-hub packages be built with python 3.7 and python 3.8? Should litex-hub simply move from python 3.7 to python 3.8?

Until these questions are answered, this PR cannot be merged. If these questions have already been asked and answered, where are the answers? Thanks.

@litghost
Copy link
Contributor

So as a concrete question, how does the labelling on litex-hub work? When do packages get the main label?

@PiotrZierhoffer
Copy link

@litghost I added a description of the transition we want to have: SymbiFlow/conda-packages#154

The process of merging in SymbiFlow/conda-packages#143 will look, I assume, quite similar.

I'll verify the Python thingy. Is conda-packages actually relying on 3.8?

Labels are attached to packages when they are built as part of a PR. When they get merged and the CI is green, they are moved to main.

@litghost
Copy link
Contributor

litghost commented Dec 4, 2020

Thanks @piotr-binkowski and @ajelinski, I've take this PR and iterated on it in #1816 to use the direct upstream vtr and yosys, as I believe those can be used now.

@litghost
Copy link
Contributor

litghost commented Dec 8, 2020

Superceed #1816

@litghost litghost closed this Dec 8, 2020
@ajelinski
Copy link
Contributor

Thanks @litghost, it's great to have it merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants