-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to packages from 'litex-hub' channel #1795
Conversation
9f219c5
to
ecff0bb
Compare
environment.yml
Outdated
- symbiflow::iverilog | ||
- symbiflow::icestorm | ||
- symbiflow::capnproto-java | ||
- litex-hub::symbiflow-yosys |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regardless of whether the packages come from symbiflow or litex-hub channel, removing version pinning right now will result in unstable builds. What is the plan to deal with incompatible packages? I'm specifically concerned with VTR and yosys packages, as those are the ones mostly likely to break.
@PiotrZierhoffer - I think we need the version pinning process here (and auto rolling bot). |
c62c474
to
9029aa2
Compare
@litghost @mithro All
|
@mithro @litghost are you able to restart
|
Signed-off-by: Tomasz Jurtsch <tjurtsch@antmicro.com>
Signed-off-by: Tomasz Jurtsch <tjurtsch@antmicro.com>
9029aa2
to
2dc873e
Compare
The branch was rebased again because theconflict on The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the move to litex-hub
, how are changes to packages introduced? What is the new process? For example, what does SymbiFlow/conda-packages#143 look like?
Also the litex-hub
packages are only built with python 3.7
, and the packages from SymbiFlow/conda-packages
are only built with python 3.8
. Should the litex-hub
packages be built with python 3.7
and python 3.8
? Should litex-hub
simply move from python 3.7
to python 3.8
?
Until these questions are answered, this PR cannot be merged. If these questions have already been asked and answered, where are the answers? Thanks.
So as a concrete question, how does the labelling on litex-hub work? When do packages get the |
@litghost I added a description of the transition we want to have: SymbiFlow/conda-packages#154 The process of merging in SymbiFlow/conda-packages#143 will look, I assume, quite similar. I'll verify the Python thingy. Is conda-packages actually relying on 3.8? Labels are attached to packages when they are built as part of a PR. When they get merged and the CI is green, they are moved to main. |
Thanks @piotr-binkowski and @ajelinski, I've take this PR and iterated on it in #1816 to use the direct upstream vtr and yosys, as I believe those can be used now. |
Superceed #1816 |
Thanks @litghost, it's great to have it merged. |
Most of the Conda dependencies are now provided via 'litex-hub' channel.